library/dao/playlistdao: Increase robustness by using prepared statements #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
commented
Jun 23, 2020
uklotzde
reviewed
Jun 23, 2020
|
Fixes #10025 Thanks for jumping in, Jan! |
Holzhaus
force-pushed
the
playlistdao-fixes
branch
from
4749440
to
95aeece
Compare
Holzhaus
force-pushed
the
playlistdao-fixes
branch
from
95aeece
to
7993234
Compare
uklotzde
reviewed
Jun 23, 2020
| return; | ||
| } | ||
|
|
||
| query.prepare(QStringLiteral( |
There was a problem hiding this comment.
MUCH (25 ms vs. 1000 ms) faster: Oh, but that doesn't cover orphaned tracks. Ignore it!
SELECT PlaylistTracks.position FROM PlaylistTracks
INNER JOIN library ON library.id=PlaylistTracks.track_id
AND library.mixxx_deleted=0
AND PlaylistTracks.playlist_id=:id
There was a problem hiding this comment.
👍 Works as is. No need to change it.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.